AnandInguva commented on code in PR #25496:
URL: https://github.com/apache/beam/pull/25496#discussion_r1113605786
##########
sdks/python/setup.py:
##########
@@ -286,6 +286,7 @@ def get_portability_package_data():
'pytest-xdist>=2.5.0,<3',
'pytest-timeout>=2.1.0,<3',
'scikit-learn>=0.20.0',
+ 'tensorflow>=1.0.0',
Review Comment:
1. TensoRT tests run on Python 3.8 because of the container image provided
by TensorRT folks contains 3.8. We need to have an automated process of
building image from Dockerfile for Python 3.7, 3.9, 3.10 and then use that
image for the tests in Dataflow.
2. Initially, these tests are very light weight IT tests, so we just run on
the DirectRunner. apart from that, I don't see any reason why we didn't run on
Dataflow. Maybe adding these postcommit tests to Dataflow suite would increase
the total time of Dataflow suite tests in the PostCommit suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
