Abacn opened a new pull request, #25612:
URL: https://github.com/apache/beam/pull/25612
It is found when reviewing #24015, whenever a new commit pushed, all (65)
precommits are triggered at once and it simply causes Jenkins send too much
GitHub API, in the following minutes:
- other PR commit push does not trigger jenkins job run in time
- finished jenkins job run stuck at reporting status to GitHub
- phrase not working
Many of these "PreCommit" are splitted from old big JavaPreCommit (for unit
test) and JavaPostCommit (for integration tests) #24584. Currently they are
triggered automatically when the change is made on java core or buildSrc. I had
the concern if this could cause problem when reviewing that PR, apparently it
is true. Given that our build system cannot handle these number of PreCommit
run at the same time, here I propose disable triggering most of these IO_Direct
(21) precommit on buildSrc and core change.
The Con is that when there is a change on dependency version (handled by
BeamModulePlugin) one needs to trigger the job by commenting on PR manually
now. Considering that every precommit is running every 6 hr and there is
another gate on release process (#25609) this should be fine.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
