TSultanov commented on code in PR #25508:
URL: https://github.com/apache/beam/pull/25508#discussion_r1118631066
##########
playground/infrastructure/helm-playground/templates/autoscaling-python.yaml:
##########
@@ -12,15 +12,27 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-apiVersion: autoscaling/v1
+apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: playground-python
spec:
- maxReplicas: 10
- minReplicas: 1
+ maxReplicas: 4
+ minReplicas: 2
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: playground-python
- targetCPUUtilizationPercentage: 90
+ metrics:
+ - type: Resource
+ resource:
+ name: cpu
+ target:
+ type: Utilization
+ averageUtilization: 95
+ - type: Resource
+ resource:
+ name: memory
+ target:
+ type: Utilization
+ averageUtilization: 80
Review Comment:
Please add a new line to the end of file
##########
playground/infrastructure/helm-playground/templates/autoscaling-scio.yaml:
##########
@@ -12,15 +12,21 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
-apiVersion: autoscaling/v1
+apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: playground-scio
spec:
- maxReplicas: 10
- minReplicas: 2
+ maxReplicas: 4
+ minReplicas: 2
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: playground-scio
- targetCPUUtilizationPercentage: 90
+ metrics:
+ - type: Resource
+ resource:
+ name: memory
+ target:
+ type: Utilization
+ averageUtilization: 80
Review Comment:
Please add a new line to the end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
