tvalentyn commented on code in PR #25666:
URL: https://github.com/apache/beam/pull/25666#discussion_r1122283857


##########
sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py:
##########
@@ -138,7 +138,7 @@ def test_cloud_ml_benchmark_criteo_fixed_workers_10GB(self):
     workflow.run(test_pipeline.get_full_options_as_args(**extra_opts))
     end_time = time.time()
 
-    metrics_table = 'cloudml_benchmark_criteo_10GB'
+    metrics_table = 'cloudml_benchmark_criteo_fixed_workers_10GB'

Review Comment:
   I would probably select around 5 workers. o



##########
sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py:
##########
@@ -138,7 +138,7 @@ def test_cloud_ml_benchmark_criteo_fixed_workers_10GB(self):
     workflow.run(test_pipeline.get_full_options_as_args(**extra_opts))
     end_time = time.time()
 
-    metrics_table = 'cloudml_benchmark_criteo_10GB'
+    metrics_table = 'cloudml_benchmark_criteo_fixed_workers_10GB'

Review Comment:
   I would probably select around 5 workers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to