TSultanov commented on code in PR #25610: URL: https://github.com/apache/beam/pull/25610#discussion_r1123048490
########## playground/frontend/playground_components/lib/src/build_metadata.g.dart: ########## @@ -0,0 +1,9 @@ +// GENERATED CODE - DO NOT MODIFY BY HAND +// +// This file is generated during deployment to contain data about the commit. +// The copy of this file stored in the repository is for development purpose +// so the project can be started locally. +// It is safe to commit changes here everytime you run code generation. +const buildCommitHash = '0d41f157812fdc3227a6ea93429d3096aa03a850' ; Review Comment: I don't like that we commit these values into the repo. Can we write something like `unknown` here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
