ahmedabu98 commented on code in PR #25706:
URL: https://github.com/apache/beam/pull/25706#discussion_r1128101888
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryExportSchemaTransformConfiguration.java:
##########
@@ -28,7 +28,7 @@
/**
* Configuration for reading from BigQuery.
*
- * <p>This class is meant to be used with {@link
BigQueryReadSchemaTransformProvider}.
+ * <p>This class is meant to be used with {@link
BigQueryExportSchemaTransformProvider}.
Review Comment:
Should still keep "Read" in there:
`BigQueryExportReadSchemaTransformProvider`
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryFileLoadsSchemaTransformConfiguration.java:
##########
@@ -27,25 +27,25 @@
/**
* Configuration for writing to BigQuery.
*
- * <p>This class is meant to be used with {@link
BigQueryWriteSchemaTransformProvider}.
+ * <p>This class is meant to be used with {@link
BigQueryFileLoadsWriteSchemaTransformProvider}.
*
* <p><b>Internal only:</b> This class is actively being worked on, and it
will likely change. We
* provide no backwards compatibility guarantees, and it should not be
implemented outside the Beam
* repository.
*/
@DefaultSchema(AutoValueSchema.class)
@AutoValue
-public abstract class BigQueryWriteSchemaTransformConfiguration {
+public abstract class BigQueryFileLoadsSchemaTransformConfiguration {
Review Comment:
wdyt of `BigQueryFileLoadsWriteSchemaTransformConfiguration`? better to keep
provider and configuration name consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
