slilichenko commented on code in PR #25723:
URL: https://github.com/apache/beam/pull/25723#discussion_r1128750282
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java:
##########
@@ -758,7 +800,24 @@ public void outputWithTimestamp(
BigQueryStorageApiInsertError output, org.joda.time.Instant
timestamp) {
context.output(failedRowsTag, output, timestamp,
GlobalWindow.INSTANCE);
}
- });
+ };
+ @Nullable OutputReceiver<TableRow> successfulRowsReceiver = null;
+ if (successfulRowsTag != null) {
+ successfulRowsReceiver =
+ new OutputReceiver<TableRow>() {
Review Comment:
That's what I thought and I understand the complexity. But it won't help
answer "are all the incoming rows in this window processed?". It will be
non-trivial to know how a unit of work (either defined as rows in a window or
identified by some id) is completed. But perhaps for some use cases having the
complete set of records is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
