TSultanov commented on code in PR #25610: URL: https://github.com/apache/beam/pull/25610#discussion_r1130651154
########## playground/backend/containers/java/Dockerfile: ########## @@ -55,6 +57,7 @@ FROM apache/beam_java8_sdk:$BEAM_VERSION ARG BEAM_VERSION ARG SPRING_VERSION=5.3.25 ARG KAFKA_CLIENTS_VERSION=2.3.1 +ENV BEAM_VERSION=$BEAM_VERSION Review Comment: This is not a runtime configuration parameter. This variable holds the value of Beam SDK version with which the image was built, so it's a compile-time parameter. Storing this value outside of the container makes little sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
