Abacn commented on code in PR #25713:
URL: https://github.com/apache/beam/pull/25713#discussion_r1131422211
##########
sdks/java/io/google-cloud-platform/build.gradle:
##########
@@ -150,19 +144,22 @@ dependencies {
implementation 'com.google.http-client:google-http-client-gson:1.41.2'
implementation "org.threeten:threetenbp:1.4.4"
- testImplementation library.java.arrow_memory_netty
testImplementation project(path: ":sdks:java:core", configuration:
"shadowTest")
testImplementation project(path: ":sdks:java:extensions:avro",
configuration: "testRuntimeMigration")
testImplementation project(path:
":sdks:java:extensions:google-cloud-platform-core", configuration:
"testRuntimeMigration")
testImplementation project(path: ":sdks:java:extensions:protobuf",
configuration: "testRuntimeMigration")
testImplementation project(path: ":runners:direct-java", configuration:
"shadow")
testImplementation project(path: ":sdks:java:io:common", configuration:
"testRuntimeMigration")
testImplementation project(path: ":sdks:java:testing:test-utils",
configuration: "testRuntimeMigration")
+ testImplementation library.java.arrow_memory_netty
+ testImplementation library.java.google_cloud_pubsub
Review Comment:
minor: may preserve the comment "// GCP PubSub client is used in TestPubSub"
Hesitated for a moment why `google_cloud_pubsub` was moved to
testImplementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
