alexeyinkin commented on code in PR #24957:
URL: https://github.com/apache/beam/pull/24957#discussion_r1131069649
##########
learning/tour-of-beam/frontend/lib/locator.dart:
##########
@@ -61,3 +64,12 @@ void _initializeState() {
),
);
}
+
+void _initializeServices() {
+ final googleAnalyticsService = GoogleAnalytics4Service(
Review Comment:
2. Renamed to `BeamAnalyticsService` and `BeamGoogleAnalyticsSevice`. I like
it better then `library.Class` because the latter is rarely used, stands out,
and questions why not import everything like that. And then we lose the Dart
simplicity.
I. In that case we will make `BeamSomethingElseAnalyticsService extends
BeamAnalyticsService`, instantiate it here and register it in `GetIt` under the
same `BeamAnalyticsService` interface. Renamed the variable to
`analyticsService` to further simplify the migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
