[GitHub] [beam] Abacn opened a new pull request, #25847: Fix excessive checkStateNotNull in JdbcUtil

Tue, 14 Mar 2023 12:01:42 -0700 


Abacn opened a new pull request, #25847:
URL: https://github.com/apache/beam/pull/25847

   * Also fix cannot write null values in derby (unit test)
   
   - The following error encountered with the new test:
   
   ```
   java.lang.RuntimeException: java.lang.RuntimeException: Error while setting 
data to preparedStatement
   org.apache.beam.sdk.Pipeline$PipelineExecutionException: 
java.lang.RuntimeException: 
   ...
   Caused by: java.sql.SQLFeatureNotSupportedException: The data type '0' is 
not supported.
        at 
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
        at 
org.apache.derby.impl.jdbc.SQLExceptionFactory.getSQLException(Unknown Source)
        at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
Source)
        at org.apache.derby.impl.jdbc.Util.generateCsSQLException(Unknown 
Source)
        at org.apache.derby.impl.jdbc.Util.checkForSupportedDataType(Unknown 
Source)
        at org.apache.derby.impl.jdbc.EmbedPreparedStatement.setNull(Unknown 
Source)
        at 
org.apache.commons.dbcp2.DelegatingPreparedStatement.setNull(DelegatingPreparedStatement.java:499)
        at 
org.apache.commons.dbcp2.DelegatingPreparedStatement.setNull(DelegatingPreparedStatement.java:499)
        at 
org.apache.beam.sdk.io.jdbc.JdbcUtil.setNullToPreparedStatement(JdbcUtil.java:272)
        at 
org.apache.beam.sdk.io.jdbc.JdbcUtil.lambda$static$aa0b0c57$3(JdbcUtil.java:109)
        at 
org.apache.beam.sdk.io.jdbc.JdbcIO$WriteVoid$AutoGeneratedPreparedStatementSetter.lambda$setParameters$1(JdbcIO.java:2207)
        ... 19 more
   Caused by: ERROR 0A000: The data type '0' is not supported.
        at org.apache.derby.iapi.error.StandardException.newException(Unknown 
Source)
        at 
org.apache.derby.impl.jdbc.SQLExceptionFactory.wrapArgsForTransportAcrossDRDA(Unknown
 Source)
        ... 30 more
   
   ```
   The data type '0' is NULL. Currently NULL primitive values are set by 
`setNullToPreparedStatement(ps, i + 1, JDBCType.NULL);`. It appears that this 
is working for some drivers (e.g. postsql), but not other (e.g. derby). 
However, the correct way should be to specify the SQL Type anyway.
   
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable. This will automatically add a link to the 
pull request in the issue. If you would like the issue to automatically close 
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual 
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more 
tips on [how to make review process 
smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit 
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   
------------------------------------------------------------------------------------------------
   [![Build python source distribution and 
wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python 
tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java 
tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go 
tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more 
information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to