tvalentyn commented on code in PR #25743:
URL: https://github.com/apache/beam/pull/25743#discussion_r1142302492


##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -1436,7 +1436,8 @@ def _check_fn_use_yield_and_return(fn):
       if has_yield and has_return:
         return True
     return False
-  except TypeError:
+  except Exception as e:
+    _LOGGER.info(str(e))

Review Comment:
   Sounds like this may cause extra noise in the logs to the users. I suggest 
_LOGGER.debug or a one-line hand-written message, or remove. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to