johannaojeling commented on code in PR #25809: URL: https://github.com/apache/beam/pull/25809#discussion_r1142596384
########## sdks/go/pkg/beam/io/fileio/match.go: ########## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// Package fileio provides transforms for matching and reading files. +package fileio + +import ( + "context" + "fmt" + "strings" + + "github.com/apache/beam/sdks/v2/go/pkg/beam" + "github.com/apache/beam/sdks/v2/go/pkg/beam/io/filesystem" + "github.com/apache/beam/sdks/v2/go/pkg/beam/register" +) + +func init() { + register.DoFn3x1[context.Context, string, func(filesystem.FileMetadata), error](&matchFn{}) + register.Emitter1[filesystem.FileMetadata]() +} + +// EmptyMatchTreatment controls how empty matches of a pattern are treated. +type EmptyMatchTreatment int + +const ( + // EmptyMatchTreatmentAllow allows empty matches. + EmptyMatchTreatmentAllow EmptyMatchTreatment = iota + // EmptyMatchTreatmentDisallow disallows empty matches. + EmptyMatchTreatmentDisallow + // EmptyMatchTreatmentAllowIfWildcard allows empty matches if the pattern contains a wildcard. + EmptyMatchTreatmentAllowIfWildcard +) + +type matchOption struct { + EmptyMatchTreatment EmptyMatchTreatment +} + +// MatchOptionFn is a function that can be passed to MatchFiles or MatchAll to configure options for +// matching files. +type MatchOptionFn func(*matchOption) error + +// WithEmptyMatchTreatment specifies how empty matches of a pattern should be treated. By default, +// empty matches are allowed if the pattern contains a wildcard. +func WithEmptyMatchTreatment(treatment EmptyMatchTreatment) MatchOptionFn { Review Comment: Also, I have to say, it's so convenient to test pipelines with prism and get feedback instantly, instead of having to wait for a Dataflow/Flink/Spark job. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
