psolomin commented on code in PR #23540:
URL: https://github.com/apache/beam/pull/23540#discussion_r1144812281
##########
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java:
##########
@@ -147,6 +150,42 @@
* Read#withCustomRateLimitPolicy(RateLimitPolicyFactory)}. This requires
implementing {@link
* RateLimitPolicy} with a corresponding {@link RateLimitPolicyFactory}.
*
+ * <h4>Enhanced Fan-Out</h4>
+ *
+ * Kinesis IO supports Consumers with Dedicated Throughput (Enhanced Fan-Out,
EFO). This type of
+ * consumer doesn't have to contend with other consumers that are receiving
data from the stream.
+ *
+ * <p>More details can be found here: <a
+ *
href="https://docs.aws.amazon.com/streams/latest/dev/enhanced-consumers.html";>Consumers
with
+ * Dedicated Throughput</a>
+ *
+ * <p>EFO can be enabled for one or more {@link KinesisIO.Read} instances via
pipeline options:
Review Comment:
@mosche it looks like in Beam 2.46.0 we have an issue with `Read`: original
class and generated class IDs don't match.
```
$ serialver -classpath "target/dependency/*" \
org.apache.beam.sdk.io.aws2.kinesis.KinesisIO.Read
org.apache.beam.sdk.io.aws2.kinesis.KinesisIO.Read: private static final
long serialVersionUID = 1118639910791038161L;
$ serialver -classpath "target/dependency/*" \
org.apache.beam.sdk.io.aws2.kinesis.AutoValue_KinesisIO_Read
org.apache.beam.sdk.io.aws2.kinesis.AutoValue_KinesisIO_Read: private
static final long serialVersionUID = 410184916277145716L;
```
If I set `serialVersionUID` in `Read`, `AutoValue_KinesisIO_Read` gets the
same one - still not matching the Beam 2.46.0
Any tips? If there is no way to have IDs in `Read` and
`AutoValue_KinesisIO_Read` both hard-coded to different values, what should be
the way forward?
- Keep `Read` unchanged in this PR, create a separate issue and have
compatibility-breaking change for savepoints in other release
- Break savepoint compatibility in this PR, adding a note to the changelog
accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
