ibzib commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r457644766
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/SparkMetricsContainerStepMap.java
##########
@@ -27,7 +27,7 @@
@Override
public String toString() {
- return new SparkBeamMetric().renderAll().toString();
+ return asAttemptedOnlyMetricResults(this).toString();
Review comment:
Thanks for the heads up. My assumption in #11369 was that the result was
meant to be consumed by code, not humans. After this change, metrics would
remain not too readable for Flink. Ideally we could find a way to make the
Flink metrics protos available to the Python client without `toString`, since
`toString` should generally should be human-readable. The problem is that
without a job server, there's nowhere to access job information like metrics
outside of what Flink provides natively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
