reuvenlax commented on code in PR #25940:
URL: https://github.com/apache/beam/pull/25940#discussion_r1145587740
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/StreamingViewOverrides.java:
##########
@@ -63,8 +61,21 @@ private
StreamingCreatePCollectionView(PCollectionView<ViewT> view) {
@Override
public PCollection<ElemT> expand(PCollection<ElemT> input) {
- return input
- .apply(Combine.globally(new
Concatenate<ElemT>()).withoutDefaults())
+ PCollection<List<ElemT>> elements;
+ if (view.getViewFn() instanceof PCollectionViews.IsSingletonView) {
Review Comment:
the URN of a singleton view is beam:side_input:iterable:v1 unfortunately, so
we can't use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
