[GitHub] [beam] RustedBones commented on a diff in pull request #25713: Move beam-sdks-java-io-google-cloud-platform test implementations to test scope

Thu, 23 Mar 2023 01:35:08 -0700 


RustedBones commented on code in PR #25713:
URL: https://github.com/apache/beam/pull/25713#discussion_r1145841355


##########
runners/google-cloud-dataflow-java/examples-streaming/build.gradle:
##########
@@ -47,6 +47,9 @@ task windmillPreCommit(type: Test) {
      "--tempRoot=${gcsTempRoot}",
      "--runner=TestDataflowRunner",
      "--dataflowWorkerJar=${dataflowWorkerJar}",
+     // Provide job with a customizable worker jar.
+     // With legacy worker jar, containerImage is set to empty (i.e. to use 
the internal build).
+     // More context and discussions can be found in PR#6694.

Review Comment:
   Just wanted to confirm that removing the `workerHarnessContainerImage` and 
running with default image works.
   
![image](https://user-images.githubusercontent.com/2845540/227146807-4456a1dd-ea2a-45f5-9074-3e58845008a2.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to