damondouglas commented on code in PR #25925:
URL: https://github.com/apache/beam/pull/25925#discussion_r1148124569


##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+  push:
+    paths: ['learning/tour-of-beam/frontend/**', 
'playground/frontend/playground_components']
+    branches: ['**']
+  pull_request:
+    paths: ['learning/tour-of-beam/frontend/**', 
'playground/frontend/playground_components']
+    branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+  group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || 
github.head_ref || github.ref }}'
+  cancel-in-progress: true
+
+jobs:
+  tour_of_beam_test:
+    name: Tour of Beam Test
+    runs-on: ubuntu-latest
+
+    env:
+      FLUTTER_VERSION: '3.7.3'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: 'Cache Flutter Dependencies'
+        uses: actions/cache@v3
+        with:
+          path: /opt/hostedtoolcache/flutter
+          key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION 
}}
+          restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+      - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: 'stable'
+
+      - name: 'Install Dependencies'
+        run: |
+          cd playground/frontend/playground_components && flutter pub get && 
cd -
+          cd playground/frontend/playground_components_dev && flutter pub get 
&& cd -
+          cd learning/tour-of-beam/frontend && flutter pub get && cd -

Review Comment:
   These need to be in the learning/tour-of-beam/frontend README.



##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+  push:
+    paths: ['learning/tour-of-beam/frontend/**', 
'playground/frontend/playground_components']
+    branches: ['**']
+  pull_request:
+    paths: ['learning/tour-of-beam/frontend/**', 
'playground/frontend/playground_components']
+    branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+  group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || 
github.head_ref || github.ref }}'
+  cancel-in-progress: true
+
+jobs:
+  tour_of_beam_test:
+    name: Tour of Beam Test
+    runs-on: ubuntu-latest
+
+    env:
+      FLUTTER_VERSION: '3.7.3'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: 'Cache Flutter Dependencies'
+        uses: actions/cache@v3
+        with:
+          path: /opt/hostedtoolcache/flutter
+          key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION 
}}
+          restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+      - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: 'stable'
+
+      - name: 'Install Dependencies'
+        run: |
+          cd playground/frontend/playground_components && flutter pub get && 
cd -
+          cd playground/frontend/playground_components_dev && flutter pub get 
&& cd -
+          cd learning/tour-of-beam/frontend && flutter pub get && cd -
+
+#      - name: 'Formatting'
+#        run: dart format --output=none --set-exit-if-changed .
+
+#      - name: 'Analyze playground_components'
+#        working-directory: playground/frontend/playground_components
+#        run: dart analyze --fatal-infos
+
+#      - name: 'Analyze playground_components_dev'
+#        working-directory: playground/frontend/playground_components_dev
+#        run: dart analyze --fatal-infos
+
+#      - name: 'Analyze playground'
+#        working-directory: playground/frontend
+#        run: dart analyze --fatal-infos lib test
+
+      # - name: 'Test tour of beam'
+      #   working-directory: learning/tour-of-beam/frontend
+      #   run: flutter test
+
+      - uses: nanasess/setup-chromedriver@v1
+
+      - name: 'Integration tests'
+        run: |
+          chromedriver --port=4444 &
+          ./gradlew :learning:tour-of-beam:frontend:integrationTest 
-PdeviceId=web-server

Review Comment:
   This needs to go into the tob frontend README.



##########
.github/workflows/tour_of_beam_frontend_test.yml:
##########
@@ -0,0 +1,84 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Tour Of Beam Fronend Test
+
+on:
+  push:
+    paths: ['learning/tour-of-beam/frontend/**', 
'playground/frontend/playground_components']
+    branches: ['**']
+  pull_request:
+    paths: ['learning/tour-of-beam/frontend/**', 
'playground/frontend/playground_components']
+    branches: ['**']
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+  group: '${{ github.workflow }} @ ${{ github.event.pull_request.head.label || 
github.head_ref || github.ref }}'
+  cancel-in-progress: true
+
+jobs:
+  tour_of_beam_test:
+    name: Tour of Beam Test
+    runs-on: ubuntu-latest
+
+    env:
+      FLUTTER_VERSION: '3.7.3'
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: 'Cache Flutter Dependencies'
+        uses: actions/cache@v3
+        with:
+          path: /opt/hostedtoolcache/flutter
+          key: ${{ runner.OS }}-flutter-install-cache-${{ env.FLUTTER_VERSION 
}}
+          restore-keys: ${{ runner.OS }}-flutter-install-cache
+
+      - uses: subosito/flutter-action@v2
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+          channel: 'stable'
+
+      - name: 'Install Dependencies'
+        run: |
+          cd playground/frontend/playground_components && flutter pub get && 
cd -
+          cd playground/frontend/playground_components_dev && flutter pub get 
&& cd -
+          cd learning/tour-of-beam/frontend && flutter pub get && cd -
+
+#      - name: 'Formatting'
+#        run: dart format --output=none --set-exit-if-changed .
+
+#      - name: 'Analyze playground_components'
+#        working-directory: playground/frontend/playground_components
+#        run: dart analyze --fatal-infos
+
+#      - name: 'Analyze playground_components_dev'
+#        working-directory: playground/frontend/playground_components_dev
+#        run: dart analyze --fatal-infos
+
+#      - name: 'Analyze playground'
+#        working-directory: playground/frontend
+#        run: dart analyze --fatal-infos lib test
+
+      # - name: 'Test tour of beam'
+      #   working-directory: learning/tour-of-beam/frontend
+      #   run: flutter test

Review Comment:
   Please delete instead of commenting out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to