ahmedabu98 commented on code in PR #25685:
URL: https://github.com/apache/beam/pull/25685#discussion_r1148659343
##########
sdks/java/expansion-service/src/test/java/org/apache/beam/sdk/expansion/service/ExpansionServiceSchemaTransformProviderTest.java:
##########
@@ -70,10 +70,10 @@ public class ExpansionServiceSchemaTransformProviderTest {
private static final Schema TEST_SCHEMATRANSFORM_CONFIG_SCHEMA =
Schema.of(
- Field.of("str1", FieldType.STRING),
- Field.of("str2", FieldType.STRING),
Field.of("int1", FieldType.INT32),
- Field.of("int2", FieldType.INT32));
+ Field.of("int2", FieldType.INT32),
+ Field.of("str1", FieldType.STRING),
+ Field.of("str2", FieldType.STRING));
Review Comment:
Schema needs to be in alphabetical order because tests use
`TypedSchemaTransformProvider`, which returns a config schema with fields that
are in alphabetical order. Recent commit that fixes encoding positions makes
this required or else we end up with encoding error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
