kennknowles commented on pull request #12202: URL: https://github.com/apache/beam/pull/12202#issuecomment-661432146
Drive by comment on commit history: clearly some of them should be squashed into one commit. I am not sure they all should be. After code review is done, it will be helpful to have a separately commit for (1) the abstraction then (2, 3, 4, ...) then implementations of the abstraction. This can enable selective cherry pick and rollback, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
