damccorm commented on code in PR #25884:
URL: https://github.com/apache/beam/pull/25884#discussion_r1149267752
##########
playground/terraform/build.gradle.kts:
##########
@@ -247,24 +247,6 @@ tasks {
}
}
-/* set Docker Registry to params from Inf */
-tasks.register("setDockerRegistry") {
Review Comment:
Why don't we need this anymore? Don't we use `docker-repository-root` below?
##########
playground/terraform/build.gradle.kts:
##########
@@ -363,140 +338,153 @@ tasks.register("deployFrontend") {
dependsOn(deploy)
}
-/* build, push, deploy Backend app */
-tasks.register("deployBackend") {
+tasks.register<TerraformTask>("setPlaygroundStaticIpAddress") {
group = "deploy"
- description = "deploy Backend app"
- //TODO please add default tag from project_environment property
- //if !(project.hasProperty("docker-tag")) {
- // project.extra.set("docker-tag",
project.property("project_environment") as String)
- //}
- val config = tasks.getByName("setDockerRegistry")
- val push = tasks.getByName("pushBack")
- val deploy = tasks.getByName("terraformApplyAppBack")
Review Comment:
Why don't we need to do this task anymore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
