mutianf commented on code in PR #25955:
URL: https://github.com/apache/beam/pull/25955#discussion_r1149819426
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -306,7 +306,9 @@ public abstract static class Read extends
PTransform<PBegin, PCollection<Row>> {
/**
* Returns the Google Cloud Bigtable instance being read from, and other
parameters.
*
- * @deprecated please use {@link #getBigtableReadOptions()}.
+ * @deprecated please set the configurations directly:
+ *
BigtableIO.read().withProjectId(projectId).withInstanceId(instanceId).withTableId(tableId)
Review Comment:
Ah thanks, my bad.. However, BigtableReadOptions and BigtableWriteOptions
are actually package private. Going forward we want customers to configure
these options directly on BigtableIO.read() or write(), so there won't be one
getter that'll show all the configuration. I updated the doc to use
populateDisplayData instead, do you think this will work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
