yifanmai commented on a change in pull request #12185:
URL: https://github.com/apache/beam/pull/12185#discussion_r457799457
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -289,6 +289,8 @@ def create_stages(
phases=[
translations.annotate_downstream_side_inputs,
translations.fix_side_input_pcoll_coders,
+ translations.eliminate_common_siblings,
Review comment:
As we discussed in a separate conversation, we would probably need a
design or RFC for annotating DoFns are idempotent. As such, I've removed
eliminate_common_siblings from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
