pranavbhandari24 commented on code in PR #25824:
URL: https://github.com/apache/beam/pull/25824#discussion_r1152411482
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java:
##########
@@ -627,8 +644,32 @@ && getConnectionInitSqls().get() != null
if (getMaxConnections() != null && getMaxConnections().get() != null) {
basicDataSource.setMaxTotal(getMaxConnections().get());
}
- if (getDriverClassLoader() != null) {
- basicDataSource.setDriverClassLoader(getDriverClassLoader());
+ if (getDriverJarDirectory() != null && getDriverJarDirectory().get()
!= null) {
+ try {
+ String pathPrefix =
+ getDriverJarDirectory().get().endsWith("/")
Review Comment:
Moved to util file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
