aromanenko-dev commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r458073027
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/SparkMetricsContainerStepMap.java
##########
@@ -27,7 +27,7 @@
@Override
public String toString() {
- return new SparkBeamMetric().renderAll().toString();
+ return asAttemptedOnlyMetricResults(this).toString();
Review comment:
@ibzib Thanks for details. I agree that we should not rely on
`toString()` when it's going to be used by other program.
I'm sorry but I'm not sure that I fully understand your last sentence - does
it seem that it's only specific Flink-related issue?
Regarding readable Flink metrics - would it be better to fix it on
FlinkRunner side, like we do with `SparkMetricsContainerStepMap` for Spark
Runner?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
