nielm commented on code in PR #26007:
URL: https://github.com/apache/beam/pull/26007#discussion_r1155065869
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java:
##########
@@ -109,20 +112,26 @@ public static SpannerAccessor getOrCreate(SpannerConfig
spannerConfig) {
private static SpannerAccessor createAndConnect(SpannerConfig spannerConfig)
{
SpannerOptions.Builder builder = SpannerOptions.newBuilder();
- // Set retryable codes for all API methods
+ Set<Code> retryableCodes = new HashSet<>();
if (spannerConfig.getRetryableCodes() != null) {
- builder
- .getSpannerStubSettingsBuilder()
- .applyToAllUnaryMethods(
- input -> {
- input.setRetryableCodes(spannerConfig.getRetryableCodes());
- return null;
- });
- builder
- .getSpannerStubSettingsBuilder()
- .executeStreamingSqlSettings()
- .setRetryableCodes(spannerConfig.getRetryableCodes());
+ retryableCodes.addAll(spannerConfig.getRetryableCodes());
+ }
+ if (spannerConfig.getDataBoostEnabled() != null
+ && Boolean.TRUE.equals(spannerConfig.getDataBoostEnabled().get())) {
Review Comment:
Same comment as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
