aromanenko-dev commented on code in PR #25216:
URL: https://github.com/apache/beam/pull/25216#discussion_r1158477100
##########
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/schemas/AvroSchemaTest.java:
##########
@@ -302,23 +304,8 @@ public String toString() {
private static final DateTime DATE_TIME =
new DateTime().withDate(1979, 3, 14).withTime(1, 2, 3, 4);
private static final LocalDate DATE = new LocalDate(1979, 3, 14);
- private static final TestAvroNested AVRO_NESTED_SPECIFIC_RECORD = new
TestAvroNested(true, 42);
private static final TestAvro AVRO_SPECIFIC_RECORD =
- new TestAvro(
- true,
- 43,
- 44L,
- (float) 44.1,
- (double) 44.2,
- "mystring",
- ByteBuffer.wrap(BYTE_ARRAY),
- new fixed4(BYTE_ARRAY),
- DATE,
- DATE_TIME,
- TestEnum.abc,
- AVRO_NESTED_SPECIFIC_RECORD,
- ImmutableList.of(AVRO_NESTED_SPECIFIC_RECORD,
AVRO_NESTED_SPECIFIC_RECORD),
- ImmutableMap.of("k1", AVRO_NESTED_SPECIFIC_RECORD, "k2",
AVRO_NESTED_SPECIFIC_RECORD));
+ TestAvroFactory.newInstanceForAvroSchemaTest();
Review Comment:
Empty maps logic is implemented inside
`AvroCoderTest.testSpecificRecordEncoding()` that was failing because of this
issue in recent Avro versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
