rshamunov commented on code in PR #25117:
URL: https://github.com/apache/beam/pull/25117#discussion_r1158684024
##########
playground/terraform/infrastructure/cloudbuild-manual-setup/02.builders/variables.tf:
##########
@@ -16,76 +16,72 @@
# under the License.
variable "project_id" {
- type = string
description = "The ID of the Google Cloud project within which resources are
provisioned"
}
-variable "region" {
- type = string
- description = "The Google Cloud Platform (GCP) region (For example:
us-central1) where Cloud Build triggers will be created at"
-}
-
-variable "infra_trigger_name" {
- type = string
+variable "pg_infra_trigger_name" {
description = "The name of the trigger that will deploy Playground
infrastructure"
- default = "playground-infrastructure-trigger"
+ default = "Playground-infrastructure-trigger"
Review Comment:
Rename triggers Display name. E.g.:
Initialize Playground environment
Deploy Playground environment
Update Playground environment
Validate examples (CI)
Deploy examples (CD)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
