BjornPrime commented on code in PR #25965: URL: https://github.com/apache/beam/pull/25965#discussion_r1159854581
########## sdks/python/apache_beam/io/gcp/gcsio.py: ########## @@ -162,20 +144,13 @@ class GcsIOError(IOError, retry.PermanentException): class GcsIO(object): """Google Cloud Storage I/O client.""" def __init__(self, storage_client=None, pipeline_options=None): - # type: (Optional[storage.StorageV1], Optional[Union[dict, PipelineOptions]]) -> None Review Comment: Yeah, I guess I can just update storage.StorageV1 to storage.Client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
