lostluck commented on PR #26183: URL: https://github.com/apache/beam/pull/26183#issuecomment-1501265192
The dummy is only generated on the skip path. And in the skip path, the entire folder for licenses is deleted. An explicit delete is redundant. On Sun, Apr 9, 2023, 5:49 PM Danny McCormick ***@***.***> wrote: > ***@***.**** approved this pull request. > > LGTM - I'm fine with merging without my comment if you think removing the > touched file is not worth it for any reason > ------------------------------ > > In sdks/go/container/Dockerfile > <https://github.com/apache/beam/pull/26183#discussion_r1161364457>: > > > @@ -34,11 +35,8 @@ ADD target/${TARGETOS}_${TARGETARCH}/boot /opt/apache/beam/ > COPY target/LICENSE /opt/apache/beam/ > COPY target/NOTICE /opt/apache/beam/ > > -# Add golang licenses. Because the go-license directory may be empty if > -# pull_licenses is false, and COPY fails if there are no files, > -# copy an extra LICENSE file then remove it. > -COPY target/LICENSE target/go-licenses/* /opt/apache/beam/third_party_licenses/golang/ > -RUN rm /opt/apache/beam/third_party_licenses/golang/LICENSE > +# Add Go licenses. > +COPY target/go-licenses/* /opt/apache/beam/third_party_licenses/golang/ > > Should we be rming the touched file? That is also simpler if we do the > file touch as part of the dockerfile > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/26183#pullrequestreview-1376978603>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFLW5D27NT2BPORNAO3XANKH3ANCNFSM6AAAAAAWW6JNDQ> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
