TSultanov commented on code in PR #25791:
URL: https://github.com/apache/beam/pull/25791#discussion_r1164243700
##########
playground/backend/internal/db/schema/migration/migrations_test.go:
##########
@@ -61,8 +57,9 @@ func setup() {
}
func teardown() {
- if err := datastoreDb.Client.Close(); err != nil {
- panic(err)
+ clientCloseErr := datastoreDb.Close()
+ if clientCloseErr != nil {
+ panic(clientCloseErr)
Review Comment:
We don't have any other processes here and I don't think there is much merit
in complicating the error handling situation here with channels. Current code,
while not exactly following Go conventions to the letter, is cleaner in my
opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
