pskevin commented on a change in pull request #12071:
URL: https://github.com/apache/beam/pull/12071#discussion_r459125001
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##########
@@ -110,6 +137,20 @@ private void waitForReady() {
}
}
+ /**
+ * Motivation behind <i>singleInputOutputTest</i>.
+ *
+ * <ul>
+ * <li><b>Target transform</b> – {@link ParDo}
Review comment:
Acknowledged and reflected in the latest changes!
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##########
@@ -120,6 +161,20 @@ public void singleInputOutputTest() throws IOException {
PAssert.that(col).containsInAnyOrder("01", "02", "03");
}
+ /**
+ * Motivation behind <i>multiInputOutputWithSideInputTest</i>.
+ *
+ * <ul>
+ * <li><b>Target transform</b> – {@link ParDo}
Review comment:
Acknowledged and reflected in the latest changes!
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##########
@@ -135,6 +190,20 @@ public void multiInputOutputWithSideInputTest() {
PAssert.that(pTuple.get("side")).containsInAnyOrder("ss");
}
+ /**
+ * Motivation behind <i>groupByKeyTest</i>.
+ *
+ * <ul>
+ * <li><b>Target transform</b> – {@link GroupByKey}
Review comment:
Acknowledged and reflected in the latest changes!
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##########
@@ -154,6 +223,20 @@ public void groupByKeyTest() {
PAssert.that(col).containsInAnyOrder("0:1,2", "1:3");
}
+ /**
+ * Motivation behind <i>coGroupByKeyTest</i>.
+ *
+ * <ul>
+ * <li><b>Target transform</b> – {@link CoGroupByKey}
Review comment:
Acknowledged and reflected in the latest changes!
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##########
@@ -197,6 +307,19 @@ public void combinePerKeyTest() {
PAssert.that(col).containsInAnyOrder(KV.of("a", 3L), KV.of("b", 3L));
}
+ /**
+ * Motivation behind <i>flattenTest</i>.
Review comment:
Acknowledged and reflected in the latest changes!
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##########
@@ -209,6 +332,20 @@ public void flattenTest() {
PAssert.that(col).containsInAnyOrder(1L, 2L, 3L, 4L, 5L, 6L);
}
+ /**
+ * Motivation behind <i>partitionTest</i>.
Review comment:
Acknowledged and reflected in the latest changes!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
