aaltay commented on pull request #12077:
URL: https://github.com/apache/beam/pull/12077#issuecomment-662753484
> I think this should be OK as long as our trigger implementations are
correct (and in particular we're no longer treating triggers as UserFns but as
an enumerated set so that's safer too).
Ack. Do you recommend running any additional tests?
>
> LGTM. though I am curious why this would ever get invoked in a production
batch pipeline.
This is triggered by a 20 minute sliding window with 1 minute intervals and
and accumulation mode accumulating. Something like:
```
beam.WindowInto(
beam.window.SlidingWindows(size=20 * 60, period=60),
accumulation_mode=beam.transforms.trigger.AccumulationMode.ACCUMULATING,
)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
