AnandInguva commented on code in PR #26156: URL: https://github.com/apache/beam/pull/26156#discussion_r1166001624
########## sdks/python/container/run_generate_requirements.sh: ########## @@ -30,39 +30,46 @@ # You will need Python interpreters for all versions supported by Beam, see: # https://s.apache.org/beam-python-dev-wiki -if [[ $# != 2 ]]; then +if [[ $# -lt 2 ]]; then printf "Example usage: \n$> ./sdks/python/container/run_generate_requirements.sh 3.8 <sdk_tarball>" - printf "\n\twhere 3.8 is the Python major.minor version." + printf "\n\where 3.8 is the Python major.minor version." exit 1 fi PY_VERSION=$1 SDK_TARBALL=$2 +PIP_EXTRA_OPTIONS=$3 Review Comment: todo: provide default value to be "" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
