ettirapp commented on a change in pull request #12335: URL: https://github.com/apache/beam/pull/12335#discussion_r459168358
########## File path: sdks/java/io/azure/src/main/java/org/apache/beam/sdk/io/azure/blobstore/AzfsResourceId.java ########## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.azure.blobstore; + +import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument; +import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkState; + +import java.util.Objects; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import javax.annotation.Nullable; +import org.apache.beam.sdk.io.fs.ResolveOptions; +import org.apache.beam.sdk.io.fs.ResourceId; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; + +class AzfsResourceId implements ResourceId { + + static final String SCHEME = "azfs"; + + private static final Pattern AZFS_URI = + Pattern.compile("(?<SCHEME>[^:]+)://(?<ACCOUNT>[^/]+)/(?<CONTAINER>[^/]+)(?:/(?<BLOB>.*))?"); + + /** Matches a glob containing a wildcard, capturing the portion before the first wildcard. */ + private static final Pattern GLOB_PREFIX = Pattern.compile("(?<PREFIX>[^\\[*?]*)[\\[*?].*"); + + private final String account; + private final String container; + private final String blob; + + private AzfsResourceId(String account, String container, @Nullable String blob) { + // We are assuming that every resource id is either a container or a blob in a container, not + // just an account. + // This is because we will not enable users to create Azure containers through beam at this + // time. + checkArgument(!Strings.isNullOrEmpty(container), "container"); + checkArgument(!container.contains("/"), "container must not contain '/': [%s]", container); + this.account = account; + this.container = container; + this.blob = blob; + } + + static AzfsResourceId fromComponents(String account, String container, String blob) { + return new AzfsResourceId(account, container, blob); + } + + static AzfsResourceId fromComponents(String account, String container) { + return new AzfsResourceId(account, container, null); + } + + static AzfsResourceId fromUri(String uri) { + Matcher m = AZFS_URI.matcher(uri); + checkArgument(m.matches(), "Invalid AZFS URI: [%s]", uri); + checkArgument(m.group("SCHEME").equalsIgnoreCase(SCHEME), "Invalid AZFS URI scheme: [%s]", uri); + String account = m.group("ACCOUNT"); + String container = m.group("CONTAINER"); + String blob = m.group("BLOB"); + if (blob != null && blob.isEmpty()) { + blob = null; + } + return fromComponents(account, container, blob); + } + + public String getAccount() { + return account; + } + + public String getContainer() { + return container; + } + + public String getBlob() { + return blob; + } + + @Override + public String getScheme() { + return SCHEME; + } + + @Override + public boolean isDirectory() { + return (blob == null) || (blob.endsWith("/")); + } + + boolean isWildcard() { + return GLOB_PREFIX.matcher(blob).matches(); + } + + String getBlobNonWildcardPrefix() { + Matcher m = GLOB_PREFIX.matcher(blob); + checkArgument(m.matches(), String.format("Glob expression: [%s] is not expandable.", blob)); + return m.group("PREFIX"); + } + + @Override + public ResourceId getCurrentDirectory() { + if (isDirectory()) { + return this; + } + if (blob.lastIndexOf('/') == -1) { + return fromComponents(account, container); + } + return fromComponents(account, container, blob.substring(0, blob.lastIndexOf('/') + 1)); + } + + @Nullable + @Override + public String getFilename() { + if (blob == null) { + return null; + } + if (!isDirectory()) { + return blob.substring(blob.lastIndexOf('/') + 1); + } + String blobWithoutTrailingSlash = blob.substring(0, blob.length() - 1); + return blobWithoutTrailingSlash.substring(blobWithoutTrailingSlash.lastIndexOf('/') + 1); + } + + // TODO: ensure that this function lines up with what the filesystem match method expects + @Override + public String toString() { + if (blob != null) { + return String.format("%s://%s/%s/%s", SCHEME, account, container, blob); + } + return String.format("%s://%s/%s/", SCHEME, account, container); + } + + @Override + public boolean equals(Object obj) { + if (!(obj instanceof AzfsResourceId)) { + return false; + } + String otherBlob = ((AzfsResourceId) obj).blob; + boolean equalBlob = blob != null && otherBlob != null && blob.equals(otherBlob); + boolean noBlobs = blob == null && otherBlob == null; + return account.equals(((AzfsResourceId) obj).account) + && container.equals(((AzfsResourceId) obj).container) + && (equalBlob || noBlobs); + } + + @Override + public int hashCode() { + return Objects.hash(account, container, blob); + } + + @Override + public ResourceId resolve(String other, ResolveOptions resolveOptions) { + checkState(isDirectory(), "Expected this resource to be a directory, but was [%s]", toString()); + // TODO: check if resolve options are an illegal name in any way, see: + // https://docs.microsoft.com/en-us/rest/api/storageservices/Naming-and-Referencing-Containers--Blobs--and-Metadata + + if (resolveOptions == ResolveOptions.StandardResolveOptions.RESOLVE_DIRECTORY) { + if ("..".equals(other)) { + if ("/".equals(blob)) { + return this; + } + int parentStopsAt = blob.substring(0, blob.length() - 1).lastIndexOf('/'); + return fromComponents(account, container, blob.substring(0, parentStopsAt + 1)); + } + + if ("".equals(other)) { + return this; + } + + if (!other.endsWith("/")) { + other += "/"; + } + if (AZFS_URI.matcher(other).matches()) { + return fromUri(other); + } + if (blob == null) { + return fromComponents(account, container, other); + } + return fromComponents(account, container, blob + other); + } + + if (resolveOptions == ResolveOptions.StandardResolveOptions.RESOLVE_FILE) { + checkArgument( + !other.endsWith("/"), "Cannot resolve a file with a directory path: [%s]", other); + checkArgument(!"..".equals(other), "Cannot resolve parent as file: [%s]", other); + if (AZFS_URI.matcher(other).matches()) { + return fromUri(other); + } + if (blob == null) { + return fromComponents(account, container, other); + } + return fromComponents(account, container, blob + other); + } + + throw new UnsupportedOperationException( + String.format("Unexpected StandardResolveOptions [%s]", resolveOptions)); + } + + // url format to interact with Azure + public String toAzureUrl() { Review comment: I think I will need it later to interact with the Azure client, but I will remove it for now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
