piotr-szuberski commented on a change in pull request #12297:
URL: https://github.com/apache/beam/pull/12297#discussion_r459261349
##########
File path:
sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/KinesisIO.java
##########
@@ -536,6 +537,13 @@ public Read withMaxCapacityPerShard(Integer maxCapacity) {
return toBuilder().setMaxCapacityPerShard(maxCapacity).build();
}
+ /**
+ * Returns a {@link PTransform} for PCollection of {@link byte[]},
dropping Kinesis metatdata.
+ */
+ public PTransform<PBegin, PCollection<byte[]>> withoutMetadata() {
+ return new TypedWithoutMetadata(this);
+ }
Review comment:
Thanks for pointing it, I followed the KafkaIO convention and didn't
think whether it's a good design or not. The change is trivial, just use
KinesisIO.readWithoutMetadata() and pass Read there instead of creating it in
withoutMetadata(this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
