lostluck commented on code in PR #26192:
URL: https://github.com/apache/beam/pull/26192#discussion_r1171920081
##########
sdks/go/pkg/beam/io/filesystem/filesystem.go:
##########
@@ -92,6 +93,12 @@ type Interface interface {
// The following interfaces are optional for the filesystems, but
// to support
+// LastModifiedGetter is an interface for getting the last modified time
+// of a file.
+type LastModifiedGetter interface {
Review Comment:
When I last updated the design around this, the intent was to have several
as optional methods as interfaces since some operations may be infeasible for a
given files system. Adding to the core interface is a backwards incompatible
change for (the granted, likely few) users who have a private implementation,
even if they're all updated here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
