pranavbhandari24 commented on code in PR #25824:
URL: https://github.com/apache/beam/pull/25824#discussion_r1172715560
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java:
##########
@@ -583,17 +587,35 @@ public DataSourceConfiguration
withDriverClassLoader(ClassLoader driverClassLoad
return builder().setDriverClassLoader(driverClassLoader).build();
}
+ /**
+ * Comma separated Cloud Storage paths for JDBC drivers. If not specified,
the default class
+ * loader is used to load the jars.
Review Comment:
That's true. Changed the comment, thanks!
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcUtil.java:
##########
@@ -61,6 +73,42 @@
/** Provides utility functions for working with {@link JdbcIO}. */
class JdbcUtil {
+ private static final Logger LOG = LoggerFactory.getLogger(JdbcUtil.class);
+
+ /** Utility method to save jar files locally in the worker. */
+ static URL[] saveFilesLocally(String driverJars) {
Review Comment:
Added a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
