xinyuiscool commented on code in PR #26276:
URL: https://github.com/apache/beam/pull/26276#discussion_r1172872669


##########
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/SamzaPipelineTranslator.java:
##########
@@ -107,6 +114,47 @@ public static void createConfig(
     pipeline.traverseTopologically(visitor);
   }
 
+  /**
+   * Builds a map from PTransform to its input and output PValues. The map is 
serialized and stored
+   * in the job config.
+   */
+  public static Map<String, Map.Entry<String, String>> buildTransformIOMap(

Review Comment:
   Move this to the json renderer class. This method has nothing to do with 
translation. Please also think about whether this needs a separate scan of 
pipeline or we can consolidate with the scan inside Json renderer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to