ahmedabu98 commented on code in PR #26311: URL: https://github.com/apache/beam/pull/26311#discussion_r1173084676
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigTableReadSchemaTransformProvider.java: ########## @@ -0,0 +1,226 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.bigtable; + +import static org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkArgument; + +import com.google.auto.service.AutoService; +import com.google.auto.value.AutoValue; +import com.google.bigtable.v2.Cell; +import com.google.bigtable.v2.Column; +import com.google.bigtable.v2.Family; +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.beam.sdk.annotations.Experimental; +import org.apache.beam.sdk.annotations.Experimental.Kind; +import org.apache.beam.sdk.io.gcp.bigtable.BigTableReadSchemaTransformProvider.BigTableReadSchemaTransformConfiguration; +import org.apache.beam.sdk.schemas.AutoValueSchema; +import org.apache.beam.sdk.schemas.Schema; +import org.apache.beam.sdk.schemas.annotations.DefaultSchema; +import org.apache.beam.sdk.schemas.transforms.SchemaTransform; +import org.apache.beam.sdk.schemas.transforms.SchemaTransformProvider; +import org.apache.beam.sdk.schemas.transforms.TypedSchemaTransformProvider; +import org.apache.beam.sdk.transforms.MapElements; +import org.apache.beam.sdk.transforms.PTransform; +import org.apache.beam.sdk.transforms.SimpleFunction; +import org.apache.beam.sdk.values.PCollection; +import org.apache.beam.sdk.values.PCollectionRowTuple; +import org.apache.beam.sdk.values.Row; +import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Strings; + +/** + * An implementation of {@link TypedSchemaTransformProvider} for BigTable Read jobs configured via + * {@link BigTableReadSchemaTransformConfiguration}. + * + * <p><b>Internal only:</b> This class is actively being worked on, and it will likely change. We + * provide no backwards compatibility guarantees, and it should not be implemented outside the Beam + * repository. + */ +@Experimental(Kind.SCHEMAS) +@AutoService(SchemaTransformProvider.class) +public class BigTableReadSchemaTransformProvider + extends TypedSchemaTransformProvider<BigTableReadSchemaTransformConfiguration> { + + private static final String OUTPUT_TAG = "output"; + + public static final Schema CELL_SCHEMA = + Schema.builder() + .addStringField("value") + .addInt64Field("timestamp") + .addArrayField("labels", Schema.FieldType.array(Schema.FieldType.STRING)) + .build(); + + public static final Schema ROW_SCHEMA = + Schema.builder() + .addStringField("key") + .addMapField( + "families", + Schema.FieldType.STRING, + Schema.FieldType.map( + Schema.FieldType.STRING, + Schema.FieldType.array(Schema.FieldType.row(CELL_SCHEMA)))) + .build(); + + @Override + protected Class<BigTableReadSchemaTransformConfiguration> configurationClass() { + return BigTableReadSchemaTransformConfiguration.class; + } + + @Override + protected SchemaTransform from(BigTableReadSchemaTransformConfiguration configuration) { + return new BigTableReadSchemaTransform(configuration); + } + + @Override + public String identifier() { + return "beam:schematransform:org.apache.beam:bigtable_read:v1"; + } + + @Override + public List<String> inputCollectionNames() { + return Collections.emptyList(); + } + + @Override + public List<String> outputCollectionNames() { + return Collections.singletonList(OUTPUT_TAG); + } + + /** Configuration for reading from BigTable. */ + @DefaultSchema(AutoValueSchema.class) + @AutoValue + public abstract static class BigTableReadSchemaTransformConfiguration { + + public void validate() { Review Comment: Thank you that link is really helpful. Will move validation checks to build() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
