George-Wu commented on a change in pull request #12331: URL: https://github.com/apache/beam/pull/12331#discussion_r459692382
########## File path: sdks/python/apache_beam/io/gcp/dicomio.py ########## @@ -0,0 +1,300 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +import apache_beam as beam +import google.auth +import json +from dicomclient import DicomApiHttpClient +from apache_beam.options.pipeline_options import PipelineOptions +from apache_beam.transforms import PTransform +from apache_beam.io.filesystem import BeamIOError + + +class DicomSearch(PTransform): + """A ``PTransform`` for QIDO search metadata from Cloud DICOM api. + It takes Pcollection of dicts as input and return a Pcollection + of dict as results: + INPUT: + The input dict represents DICOM web path parameter, which hasfollowing Review comment: fixed in new code ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
