alexeyinkin commented on code in PR #26428:
URL: https://github.com/apache/beam/pull/26428#discussion_r1178836420
##########
learning/tour-of-beam/frontend/lib/pages/tour/controllers/content_tree.dart:
##########
@@ -35,29 +37,22 @@ class ContentTreeController extends ChangeNotifier {
Set<String> get expandedIds => _expandedIds;
ContentTreeController({
- required Sdk initialSdk,
+ required this.initialSdk,
List<String> initialTreeIds = const [],
- }) : _sdk = initialSdk,
- _treeIds = initialTreeIds {
+ }) : _treeIds = initialTreeIds {
_expandedIds.addAll(initialTreeIds);
_contentTreeCache.addListener(_onContentTreeCacheChange);
_onContentTreeCacheChange();
}
- Sdk get sdk => _sdk;
-
- set sdk(Sdk newValue) {
- _sdk = newValue;
- notifyListeners();
- }
-
+ Sdk get sdk => GetIt.instance.get<AppNotifier>().sdk ?? initialSdk;
List<String> get treeIds => _treeIds;
NodeModel? get currentNode => _currentNode;
void onNodePressed(NodeModel node) {
- if (node is GroupModel) {
- _onGroupPressed(node);
+ if (node is ParentNodeModel) {
+ _onParentNodePressed(node);
} else if (node is UnitModel) {
if (node != _currentNode) {
_currentNode = node;
Review Comment:
_toggleNode(node);
##########
learning/tour-of-beam/frontend/lib/pages/tour/widgets/parent_node.dart:
##########
@@ -0,0 +1,63 @@
+
Review Comment:
Delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
