RobMcKiernan commented on issue #25085:
URL: https://github.com/apache/beam/issues/25085#issuecomment-1527495787

   I just tried raising a PR, but it appears that I don't have the needed 
permissions to push to this repo. This is the diff of my PR:
   ```diff
   diff --git a/CHANGES.md b/CHANGES.md
   index 871f24bf9d..c7578a8a61 100644
   --- a/CHANGES.md
   +++ b/CHANGES.md
   @@ -254,6 +254,8 @@
      runner (such as Dataflow Runner v2) will need to provide this package and 
its dependencies.
    * Slices now use the Beam Iterable Coder. This enables cross language use, 
but breaks pipeline updates
      if a Slice type is used as a PCollection element or State API element. 
(Go)[#24339](https://github.com/apache/beam/issues/24339)
   +* Custom worker Dockerfiles must now install their dependencies in the 
global python environment. For example, when using poetry
   +  you must use `poetry config virtualenvs.create false` before installing 
deps [#25085](https://github.com/apache/beam/issues/25085)
    
    ## Deprecations
    
   diff --git 
a/website/www/site/content/en/documentation/runtime/environments.md 
b/website/www/site/content/en/documentation/runtime/environments.md
   index 17ee452a57..46a7f69209 100644
   --- a/website/www/site/content/en/documentation/runtime/environments.md
   +++ b/website/www/site/content/en/documentation/runtime/environments.md
   @@ -198,6 +198,7 @@ Beam offers a way to provide your own custom container 
image. The easiest way to
    >The version specified in the `RUN` instruction must match the version used 
to launch the pipeline.<br>
    >**Make sure that the Python or Java runtime version specified in the base 
image is the same as the version used to run the pipeline.**
    
   +>**NOTE**: When using version >=2.44.0 you must ensure dependencies are 
installed in the global python environment in the resulting image 
    
    2. [Build](https://docs.docker.com/engine/reference/commandline/build/) and 
[push](https://docs.docker.com/engine/reference/commandline/push/) the image 
using Docker.
      ```
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to