johnjcasey commented on code in PR #25824:
URL: https://github.com/apache/beam/pull/25824#discussion_r1180581030
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/SchemaUtil.java:
##########
@@ -178,7 +178,7 @@ private static BeamFieldConverter
jdbcTypeToBeamFieldConverter(
}
/** Infers the Beam {@link Schema} from {@link ResultSetMetaData}. */
- static Schema toBeamSchema(ResultSetMetaData md) throws SQLException {
+ public static Schema toBeamSchema(ResultSetMetaData md) throws SQLException {
Review Comment:
same here
##########
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/SchemaUtil.java:
##########
@@ -66,7 +66,7 @@
/** Provides utility functions for working with Beam {@link Schema} types. */
@Experimental(Kind.SCHEMAS)
-class SchemaUtil {
+public class SchemaUtil {
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
