AnandInguva commented on PR #26225: URL: https://github.com/apache/beam/pull/26225#issuecomment-1530071809
> Also is there a naming convention for the unit test I need follow? You can see some examples. For example, https://github.com/apache/beam/blob/35406e08678c08e87e4d0ef87c4f29b5bf56872a/sdks/python/apache_beam/ml/inference/pytorch_inference_test.py#LL255. There is no naming convention except for the test name should start with `test_` and the test name should clearly define what it is doing(would be easier for others to read) Also, since this is a tft test, use the pytest marker `uses_tft` so that relevant dependencies are installed to run this test. Look here https://github.com/apache/beam/blob/35406e08678c08e87e4d0ef87c4f29b5bf56872a/sdks/python/apache_beam/testing/benchmarks/cloudml/cloudml_benchmark_test.py#L59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
