Sanil15 commented on code in PR #26437:
URL: https://github.com/apache/beam/pull/26437#discussion_r1181812038
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/TranslationContext.java:
##########
@@ -145,9 +152,25 @@ protected <KeyT, OutT> void registerInputMessageStreams(
}
public <OutT> void registerMessageStream(PValue pvalue,
MessageStream<OpMessage<OutT>> stream) {
+ registerMessageStream(pvalue, stream, true);
+ }
+
+ public <OutT> void registerMessageStream(
+ PValue pvalue, MessageStream<OpMessage<OutT>> stream, boolean
enableTransformMetric) {
if (messsageStreams.containsKey(pvalue)) {
throw new IllegalArgumentException("Stream already registered for
pvalue: " + pvalue);
}
+ // add a step to attach OutputMetricOp if registered for Op Stream
+ final Config overrideConfig = new
MapConfig(getPipelineOptions().getConfigOverride());
Review Comment:
done
##########
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/TranslationContext.java:
##########
@@ -145,9 +152,25 @@ protected <KeyT, OutT> void registerInputMessageStreams(
}
public <OutT> void registerMessageStream(PValue pvalue,
MessageStream<OpMessage<OutT>> stream) {
+ registerMessageStream(pvalue, stream, true);
+ }
+
+ public <OutT> void registerMessageStream(
+ PValue pvalue, MessageStream<OpMessage<OutT>> stream, boolean
enableTransformMetric) {
Review Comment:
please check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
