y1chi commented on a change in pull request #12365: URL: https://github.com/apache/beam/pull/12365#discussion_r460201317
########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/models/auction_price.py ########## @@ -0,0 +1,28 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Result of Query2.""" +import json + + +class AuctionPrice(object): Review comment: is this needed, why not just use tuple for the result? ########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/nexmark_query_util.py ########## @@ -0,0 +1,36 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Utilities for working with NEXmark data stream.""" + + +import apache_beam as beam +from apache_beam.testing.benchmarks.nexmark.models import nexmark_model + + +def is_bid(event): + return isinstance(event, nexmark_model.Bid) + + +class ToString(beam.PTransform): Review comment: I think this is pretty redundant, and we can just use beam.Map(repr) or beam.Map(str) in any pipelines. ########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/queries/nexmark_query_util.py ########## @@ -0,0 +1,36 @@ +# Review comment: why not put the helpers in nexmark_util? one util file should be good enough to hold all related helper methods/classes. ########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/models/nexmark_model.py ########## @@ -26,27 +26,25 @@ - The bid on an item for auction (Bid). """ +import json class Person(object): "Author of an auction or a bid." def __init__( - self, id, name, email, credit_card, city, state, timestamp, extra=None): + self, id, name, email, credit_card, city, state, date_time, extra=None): self.id = id self.name = name - self.email = email # key - self.credit_card = credit_card + self.emailAddress = email # key Review comment: python's style convention uses snake case for fields, so this is normally self.email_address, ditto for below ########## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/models/field_name.py ########## @@ -0,0 +1,40 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +""" Field names for de-serializing json representation of Models +""" + + +class FieldName: Review comment: nit: FieldNames or Fields. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
