pabloem commented on a change in pull request #12203:
URL: https://github.com/apache/beam/pull/12203#discussion_r460207818



##########
File path: CHANGES.md
##########
@@ -55,6 +55,9 @@
 
 * New overloads for BigtableIO.Read.withKeyRange() and 
BigtableIO.Read.withRowFilter()
   methods that take ValueProvider as a parameter (Java) 
([BEAM-10283](https://issues.apache.org/jira/browse/BEAM-10283)).
+* The WriteToBigQuery transform (Python) in Dataflow Batch no longer relies on 
BigQuerySource by default. It relies on 

Review comment:
       Ah yes, done.

##########
File path: sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py
##########
@@ -227,6 +225,7 @@ def test_big_query_standard_sql_kms_key_native(self):
         'on_success_matcher': all_of(*pipeline_verifiers),
         'kms_key': kms_key,
         'native': True,
+        'experiments': 'use_dataflow_bq_sink',

Review comment:
       I'm trying to preserve the same test coverage after the change, and 
remove BQSink tests later on. Would htis be fine?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to