nickuncaged1201 commented on code in PR #26560:
URL: https://github.com/apache/beam/pull/26560#discussion_r1185591873
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformProvider.java:
##########
@@ -102,7 +115,37 @@ public List<String> inputCollectionNames() {
@Override
public List<String> outputCollectionNames() {
- return Lists.newArrayList("output");
+ return Arrays.asList("output", "errors");
+ }
+
+ public static class ErrorFn extends DoFn<byte[], Row> {
Review Comment:
nit: I think putting this under the SchemaTransform is a better way since
it's closer to where the class is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
