ahmedabu98 commented on code in PR #26559:
URL: https://github.com/apache/beam/pull/26559#discussion_r1187303763
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java:
##########
@@ -2684,6 +2685,52 @@ public void testWriteToTableDecorator() throws Exception
{
p.run();
}
+ @Test
+ public void testBatchStorageWriteWithMultipleAppendsPerStream() throws
Exception {
+ assumeTrue(useStorageApi);
Review Comment:
The parameters are initialized here and all the tests in this class rely on
them:
https://github.com/apache/beam/blob/f903b9c6021a87af92c9bf03c01e1a5bf6a318d6/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java#L177-L186
Should we add another test that checks for existing configurations? e.g.
check a configuration exists for streaming with storage api
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
